Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented the unmanaged cluster CRD for adopting existing k8s clusters #623

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Implemented the unmanaged cluster CRD for adopting existing k8s clusters #623

wants to merge 5 commits into from

Conversation

kylewuolle
Copy link
Contributor

Resolves #542

This PR implements adopting existing k8s clusters into 2a.

Kshatrix
Kshatrix requested changes Nov 12, 2024
View reviewed changes
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
internal/controller/unmanagedcluster_controller.go Outdated Show resolved Hide resolved
internal/controller/unmanagedcluster_controller.go Outdated Show resolved Hide resolved
internal/controller/unmanagedcluster_controller.go Show resolved Hide resolved
templates/provider/hmc/templates/rbac/controller/rolebindings.yaml Show resolved Hide resolved
templates/provider/hmc/templates/rbac/user-facing/unmanagedcluster-editor.yaml
kind: ClusterRole
metadata:
labels:
hmc.mirantis.com/aggregate-to-global-admin: "true"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think rbac considerations should be similar to managedclusters, unless it was decided otherwise

a13x5
a13x5 requested changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@a13x5 a13x5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO The design of using unmanaged cluster as an infrastructure provider looks needlessly complicated for our purposes.

Status handling logic should be reconsidered.
kubebuilder comments must be cleared out.

api/v1alpha1/unmanagedcluster_types.go Outdated Show resolved Hide resolved
api/v1alpha1/unmanagedcluster_types.go Show resolved Hide resolved
api/v1alpha1/unmanagedmachine_types.go Show resolved Hide resolved
internal/controller/unmanagedcluster_controller.go Outdated Show resolved Hide resolved
internal/controller/unmanagedcluster_controller.go Outdated Show resolved Hide resolved
internal/controller/unmanagedmachine_controller.go Outdated Show resolved Hide resolved
internal/controller/unmanagedmachine_controller.go Outdated Show resolved Hide resolved
internal/controller/unmanagedmachine_controller.go Outdated Show resolved Hide resolved
templates/provider/hmc/templates/rbac/controller/roles.yaml Outdated Show resolved Hide resolved
templates/provider/hmc/templates/rbac/controller/roles.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squizzi squizzi Awaiting requested review from squizzi

@eromanova eromanova Awaiting requested review from eromanova eromanova is a code owner

@slysunkin slysunkin Awaiting requested review from slysunkin

@a13x5 a13x5 Awaiting requested review from a13x5 a13x5 is a code owner

@Kshatrix Kshatrix Awaiting requested review from Kshatrix Kshatrix is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Project 2A
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create unmanaged cluster controller and crd
3 participants
@kylewuolle @Kshatrix @a13x5